Bug 120829

Summary: Allow string as image reference on filter()
Product: WebKit Reporter: Dirk Schulze <krit>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
kling: review+
Patch none

Dirk Schulze
Reported 2013-09-05 22:59:11 PDT
Beside <image> (which already includes url(), gradients, cross-fade() and image-set()), the filter() image function should support <string> as image reference.
Attachments
Patch (9.84 KB, patch)
2013-09-05 23:04 PDT, Dirk Schulze 		kling: review+
DetailsFormatted DiffDiff
Patch (10.86 KB, patch)
2013-09-05 23:30 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2013-09-05 23:04:23 PDT
Created attachment 210705 [details] Patch
Andreas Kling
Comment 2 2013-09-05 23:13:17 PDT
Comment on attachment 210705 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210705&action=review r=me > Source/WebCore/css/CSSParser.cpp:8092 > + if (!a) This is a terrible variable name.
Dirk Schulze
Comment 3 2013-09-05 23:30:45 PDT
Created attachment 210706 [details] Patch
WebKit Commit Bot
Comment 4 2013-09-06 00:01:39 PDT
Comment on attachment 210706 [details] Patch Clearing flags on attachment: 210706 Committed r155179: <http://trac.webkit.org/changeset/155179>
WebKit Commit Bot
Comment 5 2013-09-06 00:01:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.