Bug 120815

Summary: [MediaStream API] Allow empty MediaStreams
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, hta, jer.noble, syoichi, tommyw
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2013-09-05 17:25:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/10de838ebd0e65fd91b3bb98136941733a038bb8 The spec is a bit unclear ecactly what should happen with newly created MediaStreams that doesn't have any tracks. The current implementation is too strict and the spec is being worked upon to be clearer. In the meantime this patch doesn't set eneded to true in the constructor.
Attachments
Proposed patch (9.62 KB, patch)
2013-09-06 10:18 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2013-09-06 10:18:18 PDT
Created attachment 210767 [details] Proposed patch
Jer Noble
Comment 2 2013-09-06 11:24:06 PDT
Comment on attachment 210767 [details] Proposed patch Net negative LOC, including tests! Impressive! r=me.
WebKit Commit Bot
Comment 3 2013-09-06 11:27:54 PDT
Comment on attachment 210767 [details] Proposed patch Clearing flags on attachment: 210767 Committed r155199: <http://trac.webkit.org/changeset/155199>
WebKit Commit Bot
Comment 4 2013-09-06 11:27:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.