Bug 120815 - [MediaStream API] Allow empty MediaStreams
Summary: [MediaStream API] Allow empty MediaStreams
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
Keywords: BlinkMergeCandidate
Depends on:
Reported: 2013-09-05 17:25 PDT by Eric Carlson
Modified: 2013-09-06 11:27 PDT (History)
6 users (show)

See Also:

Proposed patch (9.62 KB, patch)
2013-09-06 10:18 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2013-09-05 17:25:08 PDT
Consider merging https://chromium.googlesource.com/chromium/blink/+/10de838ebd0e65fd91b3bb98136941733a038bb8

The spec is a bit unclear ecactly what should happen with newly created MediaStreams
that doesn't have any tracks. The current implementation is too strict and the spec
is being worked upon to be clearer. In the meantime this patch doesn't set eneded to
true in the constructor.
Comment 1 Eric Carlson 2013-09-06 10:18:18 PDT
Created attachment 210767 [details]
Proposed patch
Comment 2 Jer Noble 2013-09-06 11:24:06 PDT
Comment on attachment 210767 [details]
Proposed patch

Net negative LOC, including tests! Impressive! r=me.
Comment 3 WebKit Commit Bot 2013-09-06 11:27:54 PDT
Comment on attachment 210767 [details]
Proposed patch

Clearing flags on attachment: 210767

Committed r155199: <http://trac.webkit.org/changeset/155199>
Comment 4 WebKit Commit Bot 2013-09-06 11:27:56 PDT
All reviewed patches have been landed.  Closing bug.