Bug 120795

Summary: ScrollView::children() should return a reference.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore Misc.Assignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cmarcelo, commit-queue, jamesr, luiz, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
Patch for landing none

Andreas Kling
Reported 2013-09-05 14:18:15 PDT
ScrollView::children() should return a reference.
Attachments
Patch (9.02 KB, patch)
2013-09-05 14:26 PDT, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (9.93 KB, patch)
2013-09-05 14:38 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-05 14:26:51 PDT
Created attachment 210662 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-05 14:28:49 PDT
Attachment 210662 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebView.mm']" exit_code: 1 Source/WebCore/platform/ScrollView.h:71: Missing spaces around >> [whitespace/operators] [3] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-09-05 14:38:27 PDT
Created attachment 210665 [details] Patch for landing
WebKit Commit Bot
Comment 4 2013-09-05 14:41:47 PDT
Attachment 210665 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/js/PageScriptDebugServer.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/scrolling/ScrollingCoordinator.cpp', u'Source/WebCore/platform/ScrollView.h', u'Source/WebCore/plugins/IFrameShimSupport.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebView.mm']" exit_code: 1 Source/WebCore/platform/ScrollView.h:71: Missing spaces around >> [whitespace/operators] [3] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 5 2013-09-05 17:34:01 PDT
Comment on attachment 210665 [details] Patch for landing Clearing flags on attachment: 210665 Committed r155164: <http://trac.webkit.org/changeset/155164>
WebKit Commit Bot
Comment 6 2013-09-05 17:34:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.