Bug 120790

Summary: Clean up wtf/Compiler.h
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Anders Carlsson
Reported 2013-09-05 13:17:24 PDT
Clean up wtf/Compiler.h
Attachments
Patch (5.26 KB, patch)
2013-09-05 13:22 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-09-05 13:22:26 PDT
Created attachment 210653 [details] Patch
Andreas Kling
Comment 2 2013-09-05 13:27:54 PDT
Comment on attachment 210653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210653&action=review > Source/WTF/ChangeLog:12 > + - Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler quirk for versions of clang > + that have a buggy final implementation and fix a bug in the macro where final would be disabled > + for versions of clang where __clang_minor__ is less than 2, regardless of the major version. Whoops! > Source/WTF/wtf/Compiler.h:57 > +// Disable final on versions of Apple clang earlier than 4.2 to avoid bugs like http://webkit.org/b/119165 */ /* I think this file might need to be C compatible. */
Anders Carlsson
Comment 3 2013-09-05 14:00:34 PDT
Committed r155146: <http://trac.webkit.org/changeset/155146>
Note You need to log in before you can comment on or make changes to this bug.