Bug 120785

Summary: GCAssertions.h should use STL type traits and static_assert
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, philn, webkit-ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 146829    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch kling: review+

Description Anders Carlsson 2013-09-05 12:03:28 PDT 
GCAssertions.h should use STL type traits and static_assert
Comment 1 Anders Carlsson 2013-09-05 12:17:59 PDT 
Created attachment 210643 [details]
Patch
Comment 2 Anders Carlsson 2013-09-05 12:25:03 PDT 
…and GCC gets in the way again.
Comment 3 Early Warning System Bot 2013-09-05 12:26:26 PDT 
Comment on attachment 210643 [details]
Patch

Attachment 210643 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1695889
Comment 4 Early Warning System Bot 2013-09-05 12:27:41 PDT 
Comment on attachment 210643 [details]
Patch

Attachment 210643 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1703264
Comment 5 Anders Carlsson 2013-09-05 12:29:13 PDT 
Created attachment 210645 [details]
Patch
Comment 6 Anders Carlsson 2013-09-05 12:37:18 PDT 
Created attachment 210646 [details]
Patch
Comment 7 Anders Carlsson 2013-09-05 13:04:18 PDT 
Created attachment 210650 [details]
Patch
Comment 8 Anders Carlsson 2013-09-05 13:12:07 PDT 
Committed r155143: <http://trac.webkit.org/changeset/155143>
Comment 9 Darin Adler 2013-09-05 18:02:09 PDT 
Comment on attachment 210650 [details]
Patch

So should we use static_assert instead of our COMPILE_ASSERT macro?
Comment 10 Anders Carlsson 2013-09-06 09:09:24 PDT 
(In reply to comment #9)
> (From update of attachment 210650 [details])
> So should we use static_assert instead of our COMPILE_ASSERT macro?

Yes.