Summary: | Add new RenderBlockFlow class | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | bdakin, buildbot, commit-queue, eflews.bot, gyuyoung.kim, ossy, philn, rniwa, webkit-ews, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 84924 | ||||||||||||||
Attachments: |
|
Description
Dave Hyatt
2013-09-05 09:14:34 PDT
Created attachment 210628 [details]
Patch
Attachment 210628 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 68 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 210628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210628&action=review > Source/WebCore/rendering/RenderBlockFlow.h:21 > +/* > + * Copyright (C) 1999 Lars Knoll (knoll@kde.org) > + * (C) 1999 Antti Koivisto (koivisto@kde.org) > + * (C) 2007 David Smith (catfish.man@gmail.com) > + * Copyright (C) 2003-2013, Apple Inc. All rights reserved. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + * > + * You should have received a copy of the GNU Library General Public License > + * along with this library; see the file COPYING.LIB. If not, write to > + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + * Boston, MA 02110-1301, USA. > + */ Can't you use the Apple license? Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1697649 Created attachment 210631 [details]
Patch to try to trick EWS into building.
Created attachment 210633 [details]
Just trying to test EWS
Attachment 210633 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 69 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1701451 Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1691918 Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1709030 Landed in r155139. (In reply to comment #11) > Landed in r155139 FYI: It broke 500+ tests everywhere. I had to revert this with http://trac.webkit.org/changeset/155162 because of the failing tests. (In reply to comment #13) > I had to revert this with http://trac.webkit.org/changeset/155162 because of the failing tests. In this case this bug should be reopened. Created attachment 210781 [details]
Patch that deals with the layout test regressions
Attachment 210781 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 73 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 210781 [details] Patch that deals with the layout test regressions Attachment 210781 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1705478 Created attachment 210782 [details]
Patch
Attachment 210782 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1
Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 1 in 75 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 210782 [details] Patch Attachment 210782 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1707456 Trying again in r155211. |