Bug 120777

Summary:

Add new RenderBlockFlow class

Product:

WebKit

Reporter:

Dave Hyatt <hyatt>

Component:

Layout and Rendering

Assignee:

Dave Hyatt <hyatt>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, buildbot, commit-queue, eflews.bot, gyuyoung.kim, ossy, philn, rniwa, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

84924

Attachments:

Description	Flags
Patch	simon.fraser: review+, buildbot: commit-queue-
Patch to try to trick EWS into building.	none
Just trying to test EWS	none
Patch that deals with the layout test regressions	bdakin: review+, eflews.bot: commit-queue-
Patch	bdakin: review+, eflews.bot: commit-queue-

Dave Hyatt

Reported 2013-09-05 09:14:34 PDT

Bug for adding a new RenderBlockFlow class that is going to hold the code for actual block layout, so that we can tighten up types and not have tables, grids, flexboxes etc. inheriting members they don't need.

Attachments
Patch (66.82 KB, patch) 2013-09-05 09:57 PDT, Dave Hyatt	simon.fraser: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Patch to try to trick EWS into building. (67.48 KB, patch) 2013-09-05 10:29 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Just trying to test EWS (67.48 KB, patch) 2013-09-05 10:35 PDT, Dave Hyatt	no flags	Details Formatted Diff Diff
Patch that deals with the layout test regressions (72.74 KB, patch) 2013-09-06 12:50 PDT, Dave Hyatt	bdakin: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (76.88 KB, patch) 2013-09-06 12:57 PDT, Dave Hyatt	bdakin: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Dave Hyatt

Comment 1 2013-09-05 09:57:19 PDT

Created attachment 210628 [details] Patch

WebKit Commit Bot

Comment 2 2013-09-05 10:00:20 PDT

Attachment 210628 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 68 files If any of these errors are false positives, please file a bug against check-webkit-style.

Simon Fraser (smfr)

Comment 3 2013-09-05 10:07:08 PDT

Comment on attachment 210628 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210628&action=review > Source/WebCore/rendering/RenderBlockFlow.h:21 > +/* > + * Copyright (C) 1999 Lars Knoll (knoll@kde.org) > + * (C) 1999 Antti Koivisto (koivisto@kde.org) > + * (C) 2007 David Smith (catfish.man@gmail.com) > + * Copyright (C) 2003-2013, Apple Inc. All rights reserved. > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + * > + * You should have received a copy of the GNU Library General Public License > + * along with this library; see the file COPYING.LIB. If not, write to > + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + * Boston, MA 02110-1301, USA. > + */ Can't you use the Apple license?

Build Bot

Comment 4 2013-09-05 10:24:05 PDT

Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1697649

Dave Hyatt

Comment 5 2013-09-05 10:29:38 PDT

Created attachment 210631 [details] Patch to try to trick EWS into building.

Dave Hyatt

Comment 6 2013-09-05 10:35:33 PDT

Created attachment 210633 [details] Just trying to test EWS

WebKit Commit Bot

Comment 7 2013-09-05 10:39:43 PDT

Attachment 210633 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 69 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 8 2013-09-05 10:45:39 PDT

Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1701451

EFL EWS Bot

Comment 9 2013-09-05 12:07:03 PDT

Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1691918

EFL EWS Bot

Comment 10 2013-09-05 12:14:34 PDT

Comment on attachment 210628 [details] Patch Attachment 210628 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1709030

Dave Hyatt

Comment 11 2013-09-05 12:32:30 PDT

Landed in r155139.

Csaba Osztrogonác

Comment 12 2013-09-05 13:19:00 PDT

(In reply to comment #11) > Landed in r155139 FYI: It broke 500+ tests everywhere.

Beth Dakin

Comment 13 2013-09-05 17:28:49 PDT

I had to revert this with http://trac.webkit.org/changeset/155162 because of the failing tests.

Csaba Osztrogonác

Comment 14 2013-09-05 21:19:51 PDT

(In reply to comment #13) > I had to revert this with http://trac.webkit.org/changeset/155162 because of the failing tests. In this case this bug should be reopened.

Dave Hyatt

Comment 15 2013-09-06 12:50:36 PDT

Created attachment 210781 [details] Patch that deals with the layout test regressions

WebKit Commit Bot

Comment 16 2013-09-06 12:53:50 PDT

Attachment 210781 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 73 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 17 2013-09-06 12:56:32 PDT

Comment on attachment 210781 [details] Patch that deals with the layout test regressions Attachment 210781 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1705478

Dave Hyatt

Comment 18 2013-09-06 12:57:55 PDT

Created attachment 210782 [details] Patch

WebKit Commit Bot

Comment 19 2013-09-06 13:00:36 PDT

Attachment 210782 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/PositionIterator.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/CompositeEditCommand.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/TypingCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/rendering/LayoutState.cpp', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockFlow.cpp', u'Source/WebCore/rendering/RenderBlockFlow.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBoxModelObject.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.cpp', u'Source/WebCore/rendering/RenderDetailsMarker.h', u'Source/WebCore/rendering/RenderFieldset.cpp', u'Source/WebCore/rendering/RenderFieldset.h', u'Source/WebCore/rendering/RenderFileUploadControl.cpp', u'Source/WebCore/rendering/RenderFileUploadControl.h', u'Source/WebCore/rendering/RenderFlowThread.cpp', u'Source/WebCore/rendering/RenderFlowThread.h', u'Source/WebCore/rendering/RenderFullScreen.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderLineBoxList.cpp', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RenderListItem.h', u'Source/WebCore/rendering/RenderMeter.cpp', u'Source/WebCore/rendering/RenderMeter.h', u'Source/WebCore/rendering/RenderMultiColumnBlock.cpp', u'Source/WebCore/rendering/RenderMultiColumnBlock.h', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderObjectChildList.cpp', u'Source/WebCore/rendering/RenderProgress.cpp', u'Source/WebCore/rendering/RenderProgress.h', u'Source/WebCore/rendering/RenderRegion.cpp', u'Source/WebCore/rendering/RenderRegion.h', u'Source/WebCore/rendering/RenderRuby.cpp', u'Source/WebCore/rendering/RenderRuby.h', u'Source/WebCore/rendering/RenderRubyBase.cpp', u'Source/WebCore/rendering/RenderRubyBase.h', u'Source/WebCore/rendering/RenderRubyRun.cpp', u'Source/WebCore/rendering/RenderRubyRun.h', u'Source/WebCore/rendering/RenderRubyText.cpp', u'Source/WebCore/rendering/RenderRubyText.h', u'Source/WebCore/rendering/RenderTableCaption.cpp', u'Source/WebCore/rendering/RenderTableCaption.h', u'Source/WebCore/rendering/RenderTableCell.cpp', u'Source/WebCore/rendering/RenderTableCell.h', u'Source/WebCore/rendering/RenderTextControl.cpp', u'Source/WebCore/rendering/RenderTextControl.h', u'Source/WebCore/rendering/RenderTextControlSingleLine.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h', u'Source/WebCore/rendering/RenderingAllInOne.cpp', u'Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.cpp', u'Source/WebCore/rendering/svg/RenderSVGBlock.h']" exit_code: 1 Source/WebCore/rendering/RenderBlock.cpp:7096: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 75 files If any of these errors are false positives, please file a bug against check-webkit-style.

EFL EWS Bot

Comment 20 2013-09-06 13:24:51 PDT

Comment on attachment 210782 [details] Patch Attachment 210782 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1707456

Dave Hyatt

Comment 21 2013-09-06 13:53:53 PDT

Trying again in r155211.

Note You need to log in before you can comment on or make changes to this bug.