| Summary: | [GTK] [Meta] GtkActions and Stock Items are deprecated in gtk+ 3.10 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Pena <spenap> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | berto, brian.holt, cgarcia, eocanha, mcatanzaro, obzhirov, zan |
| Priority: | P2 | Keywords: | Gtk |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 120636, 121686 | ||
| Bug Blocks: | |||
|
Description
Simon Pena
2013-09-05 07:39:24 PDT
I would be careful with removing deprecated symbols, I think it's important to check that the dependencies are not bumped because of this, else we would be making the webkitgtk build more difficult for no reason. This is at the moment breaking debug builds on the 2.2 stable branch, with GTK+ 3.10. As a workaround we could undefine the *_DISABLE_DEPRECATED macros in the case of debug builds. I think you can already use GtkActions in current version of GTK. Not sure about stock items. (In reply to comment #3) > I think you can already use GtkActions in current version of GTK. Not sure about stock items. Sorry I meant I can already remove GtkActions in current version of GTK. (In reply to comment #2) > This is at the moment breaking debug builds on the 2.2 stable branch, with GTK+ 3.10. As a workaround we could undefine the *_DISABLE_DEPRECATED macros in the case of debug builds. Those macro definitions were removed in r155509. https://trac.webkit.org/r155509 If the problem is that there are compile warnings, I wouldn't worry too much. We don't plan to bump GTK+ requirements, and I wouldn't spend time porting to new API either (I'm not even sure there's a replacement in current glib/GTK+ API for out uses cases), if the code is going to be full of #ifdefs. We expose GtkAction in the ContextMenu API and it works pretty well, so I would keep GtkAction and stock icons until we bump the requirements to GTK 4.0. (In reply to comment #6) > If the problem is that there are compile warnings, I wouldn't worry too much. We don't plan to bump GTK+ requirements, and I wouldn't spend time porting to new API either (I'm not even sure there's a replacement in current glib/GTK+ API for out uses cases), if the code is going to be full of #ifdefs. We expose GtkAction in the ContextMenu API and it works pretty well, so I would keep GtkAction and stock icons until we bump the requirements to GTK 4.0. OK, so I guess it can be postponed for now. (In reply to comment #6) > If the problem is that there are compile warnings, I wouldn't worry too much. We don't plan to bump GTK+ requirements, and I wouldn't spend time porting to new API either (I'm not even sure there's a replacement in current glib/GTK+ API for out uses cases), if the code is going to be full of #ifdefs. We expose GtkAction in the ContextMenu API and it works pretty well, so I would keep GtkAction and stock icons until we bump the requirements to GTK 4.0. Its not that there are just compile warning, building WebKit with debug symbols fails: $ ./autogen.sh --prefix=/opt/gnome3 --libdir=/opt/gnome3/lib64 --enable-debug Source/WebKit/gtk/webkit/webkitwebview.cpp:1309:53: error: 'GTK_STOCK_CANCEL' was not declared in this scope Source/WebKit/gtk/webkit/webkitwebview.cpp:1310:53: error: 'GTK_STOCK_OPEN' was not declared in this scope (In reply to comment #8) > (In reply to comment #6) > > If the problem is that there are compile warnings, I wouldn't worry too much. We don't plan to bump GTK+ requirements, and I wouldn't spend time porting to new API either (I'm not even sure there's a replacement in current glib/GTK+ API for out uses cases), if the code is going to be full of #ifdefs. We expose GtkAction in the ContextMenu API and it works pretty well, so I would keep GtkAction and stock icons until we bump the requirements to GTK 4.0. > > Its not that there are just compile warning, building WebKit with debug symbols fails: > $ ./autogen.sh --prefix=/opt/gnome3 --libdir=/opt/gnome3/lib64 --enable-debug > > Source/WebKit/gtk/webkit/webkitwebview.cpp:1309:53: error: 'GTK_STOCK_CANCEL' was not declared in this scope > Source/WebKit/gtk/webkit/webkitwebview.cpp:1310:53: error: 'GTK_STOCK_OPEN' was not declared in this scope I removed the disabling of deprecated API under debug builds in r155509. http://trac.webkit.org/changeset/155509 *** Bug 121686 has been marked as a duplicate of this bug. *** If migrating away from stock icons turns out to be a priority at some point, maybe https://bugs.webkit.org/attachment.cgi?id=218847 (from Bug 121686) might be considered. Stock item deprecations are trivial, patches welcome to get rid of those where they exist. No reason to keep a bug open for it without a patch, because they aren't hurting anything. GtkAction is part of our API, we cannot remove it. (In reply to comment #9) > I removed the disabling of deprecated API under debug builds in r155509. > http://trac.webkit.org/changeset/155509 This is all that matters. |