Bug 120767

Summary: Remove String(RefPtr<StringImpl>) constructor
Product: WebKit Reporter: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Component: Web Template FrameworkAssignee: Mikhail Pozdnyakov <mikhail.pozdnyakov>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mikhail Pozdnyakov
Reported 2013-09-05 05:24:24 PDT
The String(RefPtr<StringImpl>) constructor should be removed for the following reasons: 1) It almost does not have clients, so it is unneeded. 2) RefPtr should never be passed by value
Attachments
patch (1.97 KB, patch)
2013-09-05 05:28 PDT, Mikhail Pozdnyakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1 2013-09-05 05:28:15 PDT
Created attachment 210604 [details] patch
Anders Carlsson
Comment 2 2013-09-05 07:03:59 PDT
Comment on attachment 210604 [details] patch Nice! Of course, when we start dabbling with move semantics we'll probably end up changing the constructor that takes a PassRefPtr back into a RefPtr constructor ;)
WebKit Commit Bot
Comment 3 2013-09-05 07:30:31 PDT
Comment on attachment 210604 [details] patch Clearing flags on attachment: 210604 Committed r155115: <http://trac.webkit.org/changeset/155115>
WebKit Commit Bot
Comment 4 2013-09-05 07:30:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.