Bug 120763

Summary: [GTK][WK2] Update ContextMenu Download API
Product: WebKit Reporter: Brian Holt <brian.holt>
Component: WebKitGTKAssignee: Brian Holt <brian.holt>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brian Holt 2013-09-05 02:10:00 PDT 
From https://bugs.webkit.org/show_bug.cgi?id=120459.

The new tags to download media to disk should be merged into the 2.2 release so the docs need updating.

Also, a new unit test for the audio tag should be added.
Comment 1 Brian Holt 2013-09-05 09:24:30 PDT 
Created attachment 210627 [details]
Patch
Comment 2 Brian Holt 2013-09-05 09:27:07 PDT 
Comment on attachment 210627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210627&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuActions.h:75
> + * @WEBKIT_CONTEXT_MENU_ACTION_DOWNLOAD_VIDEO_TO_DISK: Download video to disk. Since 2.2

Unfortunately this doesn't result in the enum appearing under the Since 2.2 section of the docs...  Perhaps there is a different way, or it doesn't matter?

> Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp:324
> +            iter = checkCurrentItemIsStockActionAndGetNext(iter, WEBKIT_CONTEXT_MENU_ACTION_ENTER_VIDEO_FULLSCREEN, Visible);

This surprised me, but without it the test will not pass!
Comment 3 WebKit Commit Bot 2013-09-05 09:27:39 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 WebKit Commit Bot 2013-09-09 06:04:27 PDT 
Comment on attachment 210627 [details]
Patch

Clearing flags on attachment: 210627

Committed r155345: <http://trac.webkit.org/changeset/155345>
Comment 5 WebKit Commit Bot 2013-09-09 06:04:32 PDT 
All reviewed patches have been landed.  Closing bug.