Bug 120762

Summary: [WK2] [GTK] Remove the test to disable AC under Wayland from WebKitWebViewGroup
Product: WebKit Reporter: Alberto Garcia <berto>
Component: WebKitGTKAssignee: Alberto Garcia <berto>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch gustavo: review+

Alberto Garcia
Reported 2013-09-05 02:05:15 PDT
We recently added code to disable accelerated compositing under Wayland (bug 120347). However that code is located in WebKitWebViewGroup, which is not used by WebKitTestRunner. One option would be to move it to webkitWebViewBaseUpdatePreferences(). But I think it would be better to just disable AC in all cases unless we actually support it, something like: #if USE(TEXTURE_MAPPER_GL) if (priv->redirectedWindow) return; #endif setAcceleratedCompositingEnabled(false);
Attachments
Patch (3.10 KB, patch)
2013-09-05 02:12 PDT, Alberto Garcia 		gustavo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alberto Garcia
Comment 1 2013-09-05 02:12:02 PDT
Created attachment 210590 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-05 02:14:50 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Gustavo Noronha (kov)
Comment 3 2013-09-05 08:27:14 PDT
Comment on attachment 210590 [details] Patch Makes sense to me. It's a bit weird conceptually that we set a pagegroup-wide policy in each view, but it seems to be the most practical way of handling this issue, and we were already doing that anyway.
Alberto Garcia
Comment 4 2013-09-05 10:09:21 PDT
Committed r155125: <http://trac.webkit.org/changeset/155125>
Note You need to log in before you can comment on or make changes to this bug.