Bug 120757

Summary:

[CSSRegions] RenderRegion::generatingElement should return a reference

Product:

WebKit

Reporter:

Mihnea Ovidenie <mihnea>

Component:

CSS

Assignee:

Mihai Maerean <mmaerean>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, hyatt, kangil.han, kondapallykalyan, macpherson, menard, WebkitBugTracker

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

57312

Attachments:

Description	Flags
patch	none

Mihnea Ovidenie

Reported 2013-09-04 23:58:16 PDT

As a follow up from https://bugs.webkit.org/show_bug.cgi?id=120397, make RenderRegion::generatingElement() return a reference instead of pointer since for regions, generatingNode cannot return 0.

Attachments
patch (6.75 KB, patch) 2013-09-09 04:52 PDT, Mihai Maerean	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mihai Maerean

Comment 1 2013-09-09 02:04:04 PDT

RenderRegionSet derives from RenderRegion. Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not.

Mihai Maerean

Comment 2 2013-09-09 04:52:13 PDT

Created attachment 211030 [details] patch

Mihnea Ovidenie

Comment 3 2013-09-11 09:46:03 PDT

(In reply to comment #1) > RenderRegionSet derives from RenderRegion. > Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not. At this moment, RenderMultiColumnSet -> RenderRegionSet -> RenderRegion and RenderMultiColumnSet is created as an anonymous block. Therefore, for this type of region, generatingElement() can return NULL. Closing this bug as invalid.

Note You need to log in before you can comment on or make changes to this bug.