Bug 120757

Summary: [CSSRegions] RenderRegion::generatingElement should return a reference
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihai Maerean <mmaerean>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kangil.han, kondapallykalyan, macpherson, menard, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
patch none

Description Mihnea Ovidenie 2013-09-04 23:58:16 PDT
As a follow up from https://bugs.webkit.org/show_bug.cgi?id=120397, make RenderRegion::generatingElement() return a reference instead of pointer since for regions, generatingNode cannot return 0.
Comment 1 Mihai Maerean 2013-09-09 02:04:04 PDT
RenderRegionSet derives from RenderRegion.
Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not.
Comment 2 Mihai Maerean 2013-09-09 04:52:13 PDT
Created attachment 211030 [details]
patch
Comment 3 Mihnea Ovidenie 2013-09-11 09:46:03 PDT
(In reply to comment #1)
> RenderRegionSet derives from RenderRegion.
> Is generatingElement() always not NULL for RenderRegionSet as well? I'm thinking not.

At this moment, RenderMultiColumnSet -> RenderRegionSet -> RenderRegion and RenderMultiColumnSet is created as an anonymous block. Therefore, for this type of region, generatingElement() can return NULL.

Closing this bug as invalid.