Bug 120756

Summary: REGRESSION(r155092): It broke run-javascriptcore-tests on linux
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
ROLLOUT of r155092 fpizlo: commit-queue-

WebKit Commit Bot
Reported 2013-09-04 23:58:03 PDT
http://trac.webkit.org/changeset/155092 broke the build: It broke run-javascriptcore-tests on linux (Requested by Ossy on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r155092 (8.52 KB, patch)
2013-09-04 23:58 PDT, WebKit Commit Bot 		fpizlo: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1 2013-09-04 23:58:21 PDT
Created attachment 210583 [details] ROLLOUT of r155092 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Filip Pizlo
Comment 2 2013-09-04 23:58:42 PDT
Comment on attachment 210583 [details] ROLLOUT of r155092 No.
Filip Pizlo
Comment 3 2013-09-04 23:59:27 PDT
If you want to call yourself a Linux maintainer, then actually do the work. Or do you want me to start landing all fixes under #if !PLATFORM(QT)?
Csaba Osztrogonác
Comment 4 2013-09-05 00:07:45 PDT
Let's leave everything broken. Who cares?
Filip Pizlo
Comment 5 2013-09-05 00:08:31 PDT
(In reply to comment #4) > Let's leave everything broken. Who cares? As I said, I've got a fix coming.
Filip Pizlo
Comment 6 2013-09-05 00:08:51 PDT
Real fix coming shortly.
Filip Pizlo
Comment 7 2013-09-05 00:19:57 PDT
Fix #1 landed in http://trac.webkit.org/changeset/155101
Filip Pizlo
Comment 8 2013-09-05 00:23:08 PDT
Fix #2 landed in http://trac.webkit.org/changeset/155103
Filip Pizlo
Comment 9 2013-09-05 00:23:20 PDT
Will watch the Linux bots to see if this fixes it.
Filip Pizlo
Comment 10 2013-09-05 01:01:40 PDT
OK, I think this is fixed. GTK+ is passing now. The others should, too. The worst case outcome of this not being fixed is that jscore-tests appear to fail. The thing that fails is an attempt to invoke newly added tests. I'd appreciate some help from Linux porters on this, particularly in getting these new tests enabled - the point of my fixes so far is to just disable the new tests. See https://bugs.webkit.org/show_bug.cgi?id=120759, which track whatever work the Linux and Windows porters need to do.
Note You need to log in before you can comment on or make changes to this bug.