Bug 120712

Summary: Link to libdispatch_debug.lib when using DebugSuffix configuration.
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, eric.carlson, glenn, jer.noble, roger_fong
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch bfulgham: review+

Roger Fong
Reported 2013-09-04 17:34:20 PDT
It currently uses the release lib (and thus dll) when compiling in DebugSuffix mode. <rdar://problem/14883216>
Attachments
patch (1.35 KB, patch)
2013-09-04 17:36 PDT, Roger Fong 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-09-04 17:36:00 PDT
Created attachment 210529 [details] patch
Brent Fulgham
Comment 2 2013-09-05 10:08:24 PDT
Comment on attachment 210529 [details] patch r=me
Roger Fong
Comment 3 2013-09-05 10:21:26 PDT
Committed: http://trac.webkit.org/changeset/155127
Brent Fulgham
Comment 4 2013-09-05 10:29:58 PDT
I think there are a couple of more places that have to be updated to have the full WebKit stack link properly. I'm working on this now for a different reason, and will post another patch related to this one. I think we still link against AVFoundationCF.dll, rather than AVFoundationCF_debug.dll, for example.
Brent Fulgham
Comment 5 2013-09-05 11:06:48 PDT
When using this change, we should also include http://trac.webkit.org/changeset/155130, as this corrects the AVFoundationCF linkage.
Note You need to log in before you can comment on or make changes to this bug.