Bug 120706

Summary: Rename StackIterator to StackVisitor.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. ggaren: review+

Mark Lam
Reported 2013-09-04 16:52:06 PDT
Renaming StackIterator to StackVisitor. Also doing some minor refactoring: - Renamed StackIterator::iterate() to StackVisitor::visit(). - Make StackVisitor::visit() a static method. - Move the instantiation of the StackVisitor instance into StackVisitor::visit() from CallFrame::iterate(). - Removed StackIterator::resetIterator() and inline its body into the StackVisitor constructor since this is the only remaining caller of it.
Attachments
the patch. (84.77 KB, patch)
2013-09-04 16:54 PDT, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-09-04 16:54:14 PDT
Created attachment 210506 [details] the patch.
Geoffrey Garen
Comment 2 2013-09-04 17:23:57 PDT
Comment on attachment 210506 [details] the patch. r=me
Mark Lam
Comment 3 2013-09-04 17:39:34 PDT
Thanks for the review. Landed in r155081: <http://trac.webkit.org/r155081>.
Note You need to log in before you can comment on or make changes to this bug.