Bug 120706

Summary: Rename StackIterator to StackVisitor.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, ggaren, gyuyoung.kim, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
the patch. ggaren: review+

Description Mark Lam 2013-09-04 16:52:06 PDT 
Renaming StackIterator to StackVisitor.  Also doing some minor refactoring:

- Renamed StackIterator::iterate() to StackVisitor::visit().
- Make StackVisitor::visit() a static method.
- Move the instantiation of the StackVisitor instance into StackVisitor::visit() from CallFrame::iterate().
- Removed StackIterator::resetIterator() and inline its body into the StackVisitor constructor since this is the only remaining caller of it.
Comment 1 Mark Lam 2013-09-04 16:54:14 PDT 
Created attachment 210506 [details]
the patch.
Comment 2 Geoffrey Garen 2013-09-04 17:23:57 PDT 
Comment on attachment 210506 [details]
the patch.

r=me
Comment 3 Mark Lam 2013-09-04 17:39:34 PDT 
Thanks for the review.  Landed in r155081: <http://trac.webkit.org/r155081>.