Bug 120702

Summary: Make ImageQualityController per-RenderView.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
andersca: review+
Patch for landing none

Andreas Kling
Reported 2013-09-04 14:55:48 PDT
Make ImageQualityController per-RenderView.
Attachments
Patch (32.68 KB, patch)
2013-09-04 15:04 PDT, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Patch for landing (32.69 KB, patch)
2013-09-04 15:17 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-09-04 15:04:39 PDT
Created attachment 210499 [details] Patch
WebKit Commit Bot
Comment 2 2013-09-04 15:08:00 PDT
Attachment 210499 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/ImageQualityController.cpp', u'Source/WebCore/rendering/ImageQualityController.h', u'Source/WebCore/rendering/RenderBoxModelObject.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderView.h']" exit_code: 1 Source/WebCore/rendering/ImageQualityController.h:71: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/WebCore/rendering/ImageQualityController.cpp:32: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/rendering/ImageQualityController.cpp:194: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-09-04 15:17:27 PDT
Created attachment 210501 [details] Patch for landing
WebKit Commit Bot
Comment 4 2013-09-04 15:46:58 PDT
Comment on attachment 210501 [details] Patch for landing Clearing flags on attachment: 210501 Committed r155077: <http://trac.webkit.org/changeset/155077>
WebKit Commit Bot
Comment 5 2013-09-04 15:47:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.