Bug 120689

Summary: RenderSVGResource shouldn't trigger relayout during render tree teardown.
Product: WebKit Reporter: Andreas Kling <kling>
Component: SVGAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, kling, kondapallykalyan, pdr, schenney, zimmermann
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Andreas Kling 2013-09-04 11:18:28 PDT 
<rdar://problem/14908967>

Exposed by assertions added in bug 120684.
Comment 1 Andreas Kling 2013-09-04 11:21:45 PDT 
Created attachment 210479 [details]
Patch
Comment 2 Antti Koivisto 2013-09-04 11:35:23 PDT 
Comment on attachment 210479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210479&action=review

> Source/WebCore/rendering/svg/RenderSVGResource.cpp:198
> +    if (needsLayout && !object->documentBeingDestroyed())
>          object->setNeedsLayout(true);

Should this test be in setNeedsLayout instead?
Comment 3 Andreas Kling 2013-09-04 11:49:54 PDT 
Comment on attachment 210479 [details]
Patch

Clearing flags on attachment: 210479

Committed r155055: <http://trac.webkit.org/changeset/155055>
Comment 4 Andreas Kling 2013-09-04 11:50:00 PDT 
All reviewed patches have been landed.  Closing bug.