Bug 120686

Summary: Move logical dimension getters/setters to FloatingObject from RenderBlock
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: New BugsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Bem Jones-Bey
Reported 2013-09-04 09:42:36 PDT
Move logical dimension getters/setters to FloatingObject from RenderBlock
Attachments
Patch (32.55 KB, patch)
2013-09-04 09:50 PDT, Bem Jones-Bey 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Bem Jones-Bey
Comment 1 2013-09-04 09:50:32 PDT
Created attachment 210472 [details] Patch
Dave Hyatt
Comment 2 2013-09-04 10:47:17 PDT
Comment on attachment 210472 [details] Patch I would like to see you make the horizontal writing mode of the block that owns the floating object be a bit on the FloatingObject. Then you have that information available, and you don't need the boolean arguments to everything.
Dave Hyatt
Comment 3 2013-09-04 10:50:50 PDT
This doesn't have to hold up the patch though, but I think it would be a good follow-up.
Dave Hyatt
Comment 4 2013-09-04 10:51:04 PDT
Comment on attachment 210472 [details] Patch r=me
WebKit Commit Bot
Comment 5 2013-09-04 11:00:27 PDT
Comment on attachment 210472 [details] Patch Clearing flags on attachment: 210472 Committed r155050: <http://trac.webkit.org/changeset/155050>
WebKit Commit Bot
Comment 6 2013-09-04 11:00:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.