Bug 120686

Summary: Move logical dimension getters/setters to FloatingObject from RenderBlock
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: New BugsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, hyatt, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Bem Jones-Bey 2013-09-04 09:42:36 PDT 
Move logical dimension getters/setters to FloatingObject from RenderBlock
Comment 1 Bem Jones-Bey 2013-09-04 09:50:32 PDT 
Created attachment 210472 [details]
Patch
Comment 2 Dave Hyatt 2013-09-04 10:47:17 PDT 
Comment on attachment 210472 [details]
Patch

I would like to see you make the horizontal writing mode of the block that owns the floating object be a bit on the FloatingObject. Then you have that information available, and you don't need the boolean arguments to everything.
Comment 3 Dave Hyatt 2013-09-04 10:50:50 PDT 
This doesn't have to hold up the patch though, but I think it would be a good follow-up.
Comment 4 Dave Hyatt 2013-09-04 10:51:04 PDT 
Comment on attachment 210472 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-09-04 11:00:27 PDT 
Comment on attachment 210472 [details]
Patch

Clearing flags on attachment: 210472

Committed r155050: <http://trac.webkit.org/changeset/155050>
Comment 6 WebKit Commit Bot 2013-09-04 11:00:30 PDT 
All reviewed patches have been landed.  Closing bug.