Bug 120646

Summary: [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
Product: WebKit Reporter: Sergio Correia (qrwteyrutiyoup) <sergio>
Component: New BugsAssignee: Sergio Correia (qrwteyrutiyoup) <sergio>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, rakuco, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sergio Correia (qrwteyrutiyoup)
Reported 2013-09-03 12:09:32 PDT
[EFL] Move ShouldGoToBackForwardListItem to the list of passing WK2 API tests
Attachments
Patch (1.34 KB, patch)
2013-09-03 12:10 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Patch (1.39 KB, patch)
2013-09-03 12:12 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2013-09-04 14:16 PDT, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sergio Correia (qrwteyrutiyoup)
Comment 1 2013-09-03 12:10:11 PDT
Since it currently (r154988) passes in both debug and release mode.
Sergio Correia (qrwteyrutiyoup)
Comment 2 2013-09-03 12:10:41 PDT
Created attachment 210397 [details] Patch
Sergio Correia (qrwteyrutiyoup)
Comment 3 2013-09-03 12:12:32 PDT
Created attachment 210398 [details] Patch Added bug number to the ChangeLog.
Gyuyoung Kim
Comment 4 2013-09-03 18:02:05 PDT
Comment on attachment 210398 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210398&action=review > Tools/ChangeLog:3 > + [EFL] Move ShouldGoToBackForwardListItem to the list of passing WK2 API tests It would be good to add [WK2] prefix as well. > Tools/ChangeLog:8 > + * TestWebKitAPI/PlatformEfl.cmake: Mark ShouldGoToBackForwardListItem as passing. Do you know what revision this test was passed ?
Sergio Correia (qrwteyrutiyoup)
Comment 5 2013-09-04 14:16:03 PDT
Created attachment 210494 [details] Patch Updated title and mentioned the revision in which the test started to pass.
Sergio Correia (qrwteyrutiyoup)
Comment 6 2013-09-04 14:17:26 PDT
Updating bug title as per Gyuyoung's request.
WebKit Commit Bot
Comment 7 2013-09-04 18:21:49 PDT
Comment on attachment 210494 [details] Patch Clearing flags on attachment: 210494 Committed r155085: <http://trac.webkit.org/changeset/155085>
WebKit Commit Bot
Comment 8 2013-09-04 18:21:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.