Bug 120629

Summary: [GTK][EFL] include missing localized string for subtitle auto track
Product: WebKit Reporter: Danilo de Paula <danilo.eu>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117008    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Danilo de Paula
Reported 2013-09-03 05:17:31 PDT
those methods are necessary to show the "Auto" track on webkitgtk
Attachments
Patch (3.12 KB, patch)
2013-09-03 05:19 PDT, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2013-09-03 06:27 PDT, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2013-09-03 10:01 PDT, Danilo de Paula 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Danilo de Paula
Comment 1 2013-09-03 05:19:28 PDT
Created attachment 210355 [details] Patch
Danilo de Paula
Comment 2 2013-09-03 06:27:56 PDT
Created attachment 210366 [details] Patch
Danilo de Paula
Comment 3 2013-09-03 06:49:47 PDT
we need https://bugs.webkit.org/show_bug.cgi?id=117008 to be accepted first.
Danilo de Paula
Comment 4 2013-09-03 10:01:00 PDT
Created attachment 210380 [details] Patch
Danilo de Paula
Comment 5 2013-09-03 10:18:18 PDT
This patch is necessary since CaptionUserPreferences will use those methods (as it already does for TrackOffMenuItemText())
WebKit Commit Bot
Comment 6 2013-09-03 11:59:07 PDT
Comment on attachment 210380 [details] Patch Clearing flags on attachment: 210380 Committed r154994: <http://trac.webkit.org/changeset/154994>
WebKit Commit Bot
Comment 7 2013-09-03 11:59:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.