Bug 120594

Summary: Remove redefined GL_COLOR_ATTACHMENT0_EXT
Product: WebKit Reporter: ChangSeok Oh <changseok>
Component: ANGLEAssignee: ChangSeok Oh <changseok>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: buildbot, jjjaquanrice, kkinnunen, mrobinson, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
changseok: review-, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 none

ChangSeok Oh
Reported 2013-09-02 01:06:37 PDT
I saw compiler complained GL_COLOR_ATTACHMENT0_EXT is redefined like below while building with gles2 and egl options enabled. CXX Source/WebCore/platform/graphics/opengl/libWebCorePlatform_la-GraphicsContext3DOpenGLCommon.lo CXX Source/WebCore/platform/graphics/opengl/libPlatform_la-Extensions3DOpenGLCommon.lo In file included from ../../Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:57:0: ../../Source/WebCore/platform/graphics/OpenGLESShims.h:47:0: warning: "GL_COLOR_ATTACHMENT0_EXT" redefined [enabled by default] In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h:37:0, from ../../Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:36: ../../Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:578:0: note: this is the location of the previous definition In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:42:0: ../../Source/ThirdParty/ANGLE/include/GLES2/gl2ext.h:578:0: warning: "GL_COLOR_ATTACHMENT0_EXT" redefined [enabled by default] In file included from ../../Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:40:0: ../../Source/WebCore/platform/graphics/OpenGLESShims.h:47:0: note: this is the location of the previous definition CXXLD libPlatform.la
Attachments
Patch (1.46 KB, patch)
2013-09-02 01:16 PDT, ChangSeok Oh 		changseok: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (460.22 KB, application/zip)
2013-09-02 02:04 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
ChangSeok Oh
Comment 1 2013-09-02 01:16:00 PDT
Created attachment 210267 [details] Patch
Build Bot
Comment 2 2013-09-02 02:04:44 PDT
Comment on attachment 210267 [details] Patch Attachment 210267 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1659884 New failing tests: fast/workers/termination-with-port-messages.html
Build Bot
Comment 3 2013-09-02 02:04:45 PDT
Created attachment 210270 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
ChangSeok Oh
Comment 4 2013-09-02 08:41:40 PDT
(In reply to comment #3) > Created an attachment (id=210270) [details] > Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 > > The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. > Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4 False alarm. I don't believe this change affects mac port.
Note You need to log in before you can comment on or make changes to this bug.