| Summary: | Add 'edgeMode' attribute to SVGFEGaussianBlur | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Schulze <krit> | ||||||||||
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dino, d-r, esprehn+autocc, fmalita, glenn, kondapallykalyan, pdr, schenney, zimmermann | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dirk Schulze
2013-09-01 09:37:25 PDT
Created attachment 210246 [details]
Patch
Created attachment 210247 [details]
Patch
Created attachment 210248 [details]
Patch
The PNG causes problems.
Attachment 210248 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop-expected.png', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-edgeMode-attr-expected.txt', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-edgeMode-attr.html', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop-expected.txt', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop.html', u'LayoutTests/svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-edgeMode-attr.js', u'LayoutTests/svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-edgeMode-prop.js', u'LayoutTests/svg/filters/svg-gaussianblur-edgeMode-duplicate-expected.svg', u'LayoutTests/svg/filters/svg-gaussianblur-edgeMode-duplicate.svg', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp', u'Source/WebCore/platform/graphics/filters/FEGaussianBlur.h', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/svg/SVGFEGaussianBlurElement.cpp', u'Source/WebCore/svg/SVGFEGaussianBlurElement.h', u'Source/WebCore/svg/SVGFEGaussianBlurElement.idl']" exit_code: 1
Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:97: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:27: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 2 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 210254 [details]
Patch
Comment on attachment 210254 [details]
Patch
Looks good.
Comment on attachment 210254 [details] Patch Clearing flags on attachment: 210254 Committed r154948: <http://trac.webkit.org/changeset/154948> All reviewed patches have been landed. Closing bug. |