Bug 120582 - Add 'edgeMode' attribute to SVGFEGaussianBlur
Summary: Add 'edgeMode' attribute to SVGFEGaussianBlur
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-01 09:37 PDT by Dirk Schulze
Modified: 2013-09-01 21:52 PDT (History)
11 users (show)

See Also:


Attachments
Patch (28.08 KB, patch)
2013-09-01 09:55 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (27.99 KB, patch)
2013-09-01 10:32 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (129.74 KB, patch)
2013-09-01 10:34 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (129.78 KB, patch)
2013-09-01 12:43 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2013-09-01 09:37:25 PDT
Add 'edgeMode' attribute to SVGFEGaussianBlur.
Comment 1 Dirk Schulze 2013-09-01 09:55:12 PDT
Created attachment 210246 [details]
Patch
Comment 2 Dirk Schulze 2013-09-01 10:32:24 PDT
Created attachment 210247 [details]
Patch
Comment 3 Dirk Schulze 2013-09-01 10:34:47 PDT
Created attachment 210248 [details]
Patch

The PNG causes problems.
Comment 4 WebKit Commit Bot 2013-09-01 10:36:54 PDT
Attachment 210248 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/mac/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop-expected.png', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-edgeMode-attr-expected.txt', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-dom-edgeMode-attr.html', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop-expected.txt', u'LayoutTests/svg/dynamic-updates/SVGFEGaussianBlurElement-svgdom-edgeMode-prop.html', u'LayoutTests/svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-dom-edgeMode-attr.js', u'LayoutTests/svg/dynamic-updates/script-tests/SVGFEGaussianBlurElement-svgdom-edgeMode-prop.js', u'LayoutTests/svg/filters/svg-gaussianblur-edgeMode-duplicate-expected.svg', u'LayoutTests/svg/filters/svg-gaussianblur-edgeMode-duplicate.svg', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp', u'Source/WebCore/platform/graphics/filters/FEGaussianBlur.h', u'Source/WebCore/rendering/FilterEffectRenderer.cpp', u'Source/WebCore/svg/SVGFEGaussianBlurElement.cpp', u'Source/WebCore/svg/SVGFEGaussianBlurElement.h', u'Source/WebCore/svg/SVGFEGaussianBlurElement.idl']" exit_code: 1
Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:97:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/graphics/filters/FEGaussianBlur.h:27:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dirk Schulze 2013-09-01 12:43:23 PDT
Created attachment 210254 [details]
Patch
Comment 6 Rob Buis 2013-09-01 19:09:34 PDT
Comment on attachment 210254 [details]
Patch

Looks good.
Comment 7 WebKit Commit Bot 2013-09-01 21:52:45 PDT
Comment on attachment 210254 [details]
Patch

Clearing flags on attachment: 210254

Committed r154948: <http://trac.webkit.org/changeset/154948>
Comment 8 WebKit Commit Bot 2013-09-01 21:52:48 PDT
All reviewed patches have been landed.  Closing bug.