Bug 120580

Summary:

EventHandler::m_frame should be a Frame&.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

HTML Editing

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, kling, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	webkit-ews: commit-queue-
Patch	eflews.bot: commit-queue-
Patch	eflews.bot: commit-queue-
Patch	darin: review+, commit-queue: commit-queue-

Andreas Kling

Reported 2013-09-01 08:33:52 PDT

EventHandler::m_frame should be a Frame&.

Attachments
Patch (79.07 KB, patch) 2013-09-01 08:35 PDT, Andreas Kling	webkit-ews: commit-queue-	Details Formatted Diff Diff
Patch (79.06 KB, patch) 2013-09-01 08:47 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (79.88 KB, patch) 2013-09-01 08:56 PDT, Andreas Kling	eflews.bot: commit-queue-	Details Formatted Diff Diff
Patch (79.97 KB, patch) 2013-09-01 10:38 PDT, Andreas Kling	darin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andreas Kling

Comment 1 2013-09-01 08:35:01 PDT

Created attachment 210243 [details] Patch

Early Warning System Bot

Comment 2 2013-09-01 08:45:19 PDT

Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1658691

EFL EWS Bot

Comment 3 2013-09-01 08:45:33 PDT

Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1679456

Early Warning System Bot

Comment 4 2013-09-01 08:47:00 PDT

Comment on attachment 210243 [details] Patch Attachment 210243 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1661695

Andreas Kling

Comment 5 2013-09-01 08:47:15 PDT

Created attachment 210244 [details] Patch Fix touch events build.

EFL EWS Bot

Comment 6 2013-09-01 08:51:35 PDT

Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1603637

Early Warning System Bot

Comment 7 2013-09-01 08:53:36 PDT

Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1658697

Early Warning System Bot

Comment 8 2013-09-01 08:54:23 PDT

Comment on attachment 210244 [details] Patch Attachment 210244 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1656702

Andreas Kling

Comment 9 2013-09-01 08:56:42 PDT

Created attachment 210245 [details] Patch :|

EFL EWS Bot

Comment 10 2013-09-01 09:01:35 PDT

Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1675527

Early Warning System Bot

Comment 11 2013-09-01 09:01:38 PDT

Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1679464

Early Warning System Bot

Comment 12 2013-09-01 09:04:06 PDT

Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1657653

EFL EWS Bot

Comment 13 2013-09-01 09:08:34 PDT

Comment on attachment 210245 [details] Patch Attachment 210245 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1675529

Andreas Kling

Comment 14 2013-09-01 10:38:18 PDT

Created attachment 210249 [details] Patch

kov's GTK+ EWS bot

Comment 15 2013-09-01 10:50:58 PDT

Comment on attachment 210249 [details] Patch Attachment 210249 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1609676

Darin Adler

Comment 16 2013-09-01 12:25:10 PDT

Comment on attachment 210249 [details] Patch GTK build failure seems like a false positive.

WebKit Commit Bot

Comment 17 2013-09-01 12:52:19 PDT

Comment on attachment 210249 [details] Patch Rejecting attachment 210249 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 210249, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ventHandler.h patching file Source/WebCore/page/Frame.cpp patching file Source/WebCore/page/efl/EventHandlerEfl.cpp patching file Source/WebCore/page/gtk/EventHandlerGtk.cpp patching file Source/WebCore/page/mac/EventHandlerMac.mm patching file Source/WebCore/page/qt/EventHandlerQt.cpp patching file Source/WebCore/page/win/EventHandlerWin.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/1658747

Andreas Kling

Comment 18 2013-09-01 13:03:13 PDT

Committed r154947: <http://trac.webkit.org/changeset/154947>

Note You need to log in before you can comment on or make changes to this bug.