Summary: | Volume slider value should be 0 when audio is muted | ||
---|---|---|---|
Product: | WebKit | Reporter: | Xabier Rodríguez Calvar <calvaris> |
Component: | New Bugs | Assignee: | Xabier Rodríguez Calvar <calvaris> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, pnormand, rniwa |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Attachments: |
Description
Xabier Rodríguez Calvar
2013-08-30 15:11:37 PDT
Created attachment 210167 [details]
Patch
Set the slider value to 0 when audio is muted.
Comment on attachment 210167 [details]
Patch
This looks OK, but it should be testable.
(In reply to comment #2) > (From update of attachment 210167 [details]) > This looks OK, but it should be testable. I'll write a test as soon as I can. Thanks! Created attachment 210213 [details]
Patch
Added test.
Comment on attachment 210213 [details] Patch Attachment 210213 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1679229 New failing tests: media/video-volume-slider.html media/volume-bar-empty-when-muted.html Created attachment 210218 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 210213 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=210213&action=review > Source/WebCore/html/shadow/MediaControls.cpp:111 > - m_volumeSlider->setVolume(m_mediaController->volume()); > + setSliderVolume(); It looks like you need to make this same change to MediaControlsApple::reset. I assume this is what makes the new test fail on the Mac bots. > LayoutTests/media/video-volume-slider.html:42 > + volume slider is implemented and mouse over the right bottom corner of<br> Nice catch. Don't the results for this test also need to be updated? Comment on attachment 210213 [details] Patch Attachment 210213 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1642400 New failing tests: media/video-volume-slider.html media/volume-bar-empty-when-muted.html Created attachment 210220 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Comment on attachment 210213 [details] Patch Attachment 210213 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1603458 New failing tests: editing/unsupported-content/table-delete-003.html editing/unsupported-content/list-type-before.html media/video-volume-slider.html editing/unsupported-content/table-type-before.html editing/unsupported-content/list-delete-003.html media/volume-bar-empty-when-muted.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/table-type-after.html editing/unsupported-content/table-delete-001.html Created attachment 210222 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
(In reply to comment #7) > > LayoutTests/media/video-volume-slider.html:42 > > + volume slider is implemented and mouse over the right bottom corner of<br> > > Nice catch. Don't the results for this test also need to be updated? Yes, they do. I think I'll file another bug and fix it unreviewed. I'll CC you anyway. Created attachment 210233 [details]
Patch
Fixed Apple problem, updated Blackberry and removed the typo that shall be corrected in another bug.
Comment on attachment 210233 [details]
Patch
Thanks!
Comment on attachment 210233 [details] Patch Clearing flags on attachment: 210233 Committed r154944: <http://trac.webkit.org/changeset/154944> All reviewed patches have been landed. Closing bug. |