Bug 120527

Summary: StyleResolver & friends should use Document&.
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, ossy, rniwa, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
webkit-ews: commit-queue-
Patch
koivisto: review+, buildbot: commit-queue-
Patch for landing none

Andreas Kling
Reported 2013-08-30 07:47:21 PDT
StyleResolver & friends should use Document&.
Attachments
Patch for EWS (39.68 KB, patch)
2013-08-30 07:54 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (41.89 KB, patch)
2013-08-30 08:17 PDT, Andreas Kling 		koivisto: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (44.99 KB, patch)
2013-08-30 08:46 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-08-30 07:54:51 PDT
Created attachment 210109 [details] Patch for EWS
Early Warning System Bot
Comment 2 2013-08-30 08:05:22 PDT
Comment on attachment 210109 [details] Patch for EWS Attachment 210109 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1635570
Early Warning System Bot
Comment 3 2013-08-30 08:05:44 PDT
Comment on attachment 210109 [details] Patch for EWS Attachment 210109 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1646120
Build Bot
Comment 4 2013-08-30 08:17:09 PDT
Comment on attachment 210109 [details] Patch for EWS Attachment 210109 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1588489
Andreas Kling
Comment 5 2013-08-30 08:17:54 PDT
Created attachment 210113 [details] Patch
Build Bot
Comment 6 2013-08-30 08:22:38 PDT
Comment on attachment 210113 [details] Patch Attachment 210113 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1648122
Early Warning System Bot
Comment 7 2013-08-30 08:30:02 PDT
Comment on attachment 210113 [details] Patch Attachment 210113 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1654104
Early Warning System Bot
Comment 8 2013-08-30 08:33:33 PDT
Comment on attachment 210113 [details] Patch Attachment 210113 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1633113
Andreas Kling
Comment 9 2013-08-30 08:46:11 PDT
Created attachment 210115 [details] Patch for landing
WebKit Commit Bot
Comment 10 2013-08-30 09:17:06 PDT
Comment on attachment 210115 [details] Patch for landing Clearing flags on attachment: 210115 Committed r154887: <http://trac.webkit.org/changeset/154887>
WebKit Commit Bot
Comment 11 2013-08-30 09:17:09 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 12 2013-08-30 10:40:55 PDT
(In reply to comment #10) > (From update of attachment 210115 [details]) > Clearing flags on attachment: 210115 > > Committed r154887: <http://trac.webkit.org/changeset/154887> FYI: It broke the GTK and EFL builds.
Csaba Osztrogonác
Comment 13 2013-09-02 05:15:05 PDT
(In reply to comment #12) > (In reply to comment #10) > > (From update of attachment 210115 [details] [details]) > > Clearing flags on attachment: 210115 > > > > Committed r154887: <http://trac.webkit.org/changeset/154887> > > FYI: It broke the GTK and EFL builds. Fix landed in http://trac.webkit.org/changeset/154894
Note You need to log in before you can comment on or make changes to this bug.