Bug 120516

Summary: Resolve unused parameter warning in FindController.cpp
Product: WebKit Reporter: Tamas Czene <tczene>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Tamas Czene
Reported 2013-08-30 01:56:24 PDT
Resolve unused parameter warning in FindController.cpp
Attachments
proposed patch (1.35 KB, patch)
2013-08-30 01:57 PDT, Tamas Czene 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tamas Czene
Comment 1 2013-08-30 01:57:56 PDT
Created attachment 210079 [details] proposed patch
Darin Adler
Comment 2 2013-08-30 08:00:12 PDT
Comment on attachment 210079 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=210079&action=review > Source/WebKit2/WebProcess/WebPage/FindController.cpp:397 > +void FindController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& graphicsContext, const IntRect& dirtyRect) Should remove the argument name entirely. There is no information conveyed by a commented-out name that repeats the type.
WebKit Commit Bot
Comment 3 2013-08-30 08:24:22 PDT
Comment on attachment 210079 [details] proposed patch Clearing flags on attachment: 210079 Committed r154883: <http://trac.webkit.org/changeset/154883>
WebKit Commit Bot
Comment 4 2013-08-30 08:24:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.