Bug 120515

Summary: Resolve unused parameter warning in WebPlatformStrategies.cpp
Product: WebKit Reporter: Tamas Czene <tczene>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Description Tamas Czene 2013-08-30 01:49:40 PDT
Resolve unused parameter warning in WebPlatformStrategies.cpp
Comment 1 Tamas Czene 2013-08-30 01:51:42 PDT
Created attachment 210078 [details]
proposed patch
Comment 2 Darin Adler 2013-08-30 07:59:37 PDT
Comment on attachment 210078 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210078&action=review

> Source/WebKit2/WebProcess/WebPage/TapHighlightController.cpp:100
> +void TapHighlightController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& context, const IntRect& /*dirtyRect*/)

Should remove the argument entirely. No need for the commented out word "pageOverlay"; it doesn’t document anything.
Comment 3 WebKit Commit Bot 2013-08-30 08:24:48 PDT
Comment on attachment 210078 [details]
proposed patch

Clearing flags on attachment: 210078

Committed r154884: <http://trac.webkit.org/changeset/154884>
Comment 4 WebKit Commit Bot 2013-08-30 08:24:49 PDT
All reviewed patches have been landed.  Closing bug.