| Summary: | new-run-webkit-tests does not respect --no-sample-on-timeout switch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
| Component: | Tools / Tests | Assignee: | Joseph Pecoraro <joepeck> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dpranke, glenn | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 210031 [details]
[PATCH] Proposed Fix
Comment on attachment 210031 [details] [PATCH] Proposed Fix Clearing flags on attachment: 210031 Committed r154857: <http://trac.webkit.org/changeset/154857> All reviewed patches have been landed. Closing bug. |
Sampling is still happening on tests that timeout even if the --no-sample-on-timeout switch is passed. shell> ./Tools/Scripts/run-webkit-tests --no-sample-on-timeout --time-out-ms=1000 test-that-times-out.html This is super frustrating, and makes running tests take a long time if the timeout.