Bug 120491

Summary: new-run-webkit-tests does not respect --no-sample-on-timeout switch
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dpranke, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-08-29 14:13:47 PDT
Sampling is still happening on tests that timeout even if the --no-sample-on-timeout switch is passed. shell> ./Tools/Scripts/run-webkit-tests --no-sample-on-timeout --time-out-ms=1000 test-that-times-out.html This is super frustrating, and makes running tests take a long time if the timeout.
Attachments
[PATCH] Proposed Fix (1.17 KB, patch)
2013-08-29 14:14 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-08-29 14:14:37 PDT
Created attachment 210031 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2013-08-29 17:09:16 PDT
Comment on attachment 210031 [details] [PATCH] Proposed Fix Clearing flags on attachment: 210031 Committed r154857: <http://trac.webkit.org/changeset/154857>
WebKit Commit Bot
Comment 3 2013-08-29 17:09:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.