Bug 120491 - new-run-webkit-tests does not respect --no-sample-on-timeout switch
Summary: new-run-webkit-tests does not respect --no-sample-on-timeout switch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-29 14:13 PDT by Joseph Pecoraro
Modified: 2013-08-29 17:09 PDT (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.17 KB, patch)
2013-08-29 14:14 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-29 14:13:47 PDT 
Sampling is still happening on tests that timeout even if the --no-sample-on-timeout switch is passed.

    shell> ./Tools/Scripts/run-webkit-tests --no-sample-on-timeout --time-out-ms=1000 test-that-times-out.html

This is super frustrating, and makes running tests take a long time if the timeout.
Comment 1 Joseph Pecoraro 2013-08-29 14:14:37 PDT 
Created attachment 210031 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-08-29 17:09:16 PDT 
Comment on attachment 210031 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 210031

Committed r154857: <http://trac.webkit.org/changeset/154857>
Comment 3 WebKit Commit Bot 2013-08-29 17:09:18 PDT 
All reviewed patches have been landed.  Closing bug.