Bug 120489

Summary: Teach DFG::Worklist and its clients that it may be reused for different kinds of compilations
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, rakuco, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 112838    
Attachments:
Description Flags
the patch ggaren: review+

Description Filip Pizlo 2013-08-29 13:56:40 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2013-08-29 14:02:57 PDT
Created attachment 210029 [details]
the patch
Comment 2 WebKit Commit Bot 2013-08-29 14:04:57 PDT
Attachment 210029 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.h', u'Source/JavaScriptCore/dfg/DFGCompilationMode.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationMode.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGPlan.cpp', u'Source/JavaScriptCore/dfg/DFGPlan.h', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/dfg/DFGPlan.h:58:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-08-29 14:14:59 PDT
(In reply to comment #2)
> Attachment 210029 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.h', u'Source/JavaScriptCore/dfg/DFGCompilationMode.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationMode.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGPlan.cpp', u'Source/JavaScriptCore/dfg/DFGPlan.h', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
> Source/JavaScriptCore/dfg/DFGPlan.h:58:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]

Fixed.

> Total errors found: 1 in 18 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2013-08-29 15:41:54 PDT
Comment on attachment 210029 [details]
the patch

r=me
Comment 5 Filip Pizlo 2013-08-29 16:44:50 PDT
Landed in http://trac.webkit.org/changeset/154854