Bug 120489 - Teach DFG::Worklist and its clients that it may be reused for different kinds of compilations
Summary: Teach DFG::Worklist and its clients that it may be reused for different kinds...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112838
  Show dependency tree / graph
 
Reported: 2013-08-29 13:56 PDT by Filip Pizlo
Modified: 2013-08-29 16:44 PDT (History)
10 users (show)

See Also:

Attachments
the patch (36.53 KB, patch)
2013-08-29 14:02 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-08-29 13:56:40 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2013-08-29 14:02:57 PDT 
Created attachment 210029 [details]
the patch
Comment 2 WebKit Commit Bot 2013-08-29 14:04:57 PDT 
Attachment 210029 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.h', u'Source/JavaScriptCore/dfg/DFGCompilationMode.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationMode.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGPlan.cpp', u'Source/JavaScriptCore/dfg/DFGPlan.h', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
Source/JavaScriptCore/dfg/DFGPlan.h:58:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2013-08-29 14:14:59 PDT 
(In reply to comment #2)
> Attachment 210029 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/Target.pri', u'Source/JavaScriptCore/bytecode/CodeBlock.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationKey.h', u'Source/JavaScriptCore/dfg/DFGCompilationMode.cpp', u'Source/JavaScriptCore/dfg/DFGCompilationMode.h', u'Source/JavaScriptCore/dfg/DFGDriver.cpp', u'Source/JavaScriptCore/dfg/DFGDriver.h', u'Source/JavaScriptCore/dfg/DFGPlan.cpp', u'Source/JavaScriptCore/dfg/DFGPlan.h', u'Source/JavaScriptCore/dfg/DFGWorklist.cpp', u'Source/JavaScriptCore/dfg/DFGWorklist.h', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1
> Source/JavaScriptCore/dfg/DFGPlan.h:58:  The parameter name "mode" adds no information, so it should be removed.  [readability/parameter_name] [5]

Fixed.

> Total errors found: 1 in 18 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Geoffrey Garen 2013-08-29 15:41:54 PDT 
Comment on attachment 210029 [details]
the patch

r=me
Comment 5 Filip Pizlo 2013-08-29 16:44:50 PDT 
Landed in http://trac.webkit.org/changeset/154854