Bug 120462

Summary: Performance tester bots should report the number of failing tests
Product: WebKit Reporter: Gábor Ábrahám <abrhm>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kadam, lforschler, ossy, rniwa, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77037    
Attachments:
Description Flags
Proposed patch none

Gábor Ábrahám
Reported 2013-08-29 04:36:20 PDT
It would be easier to track Perf test results with this change.
Attachments
Proposed patch (1.43 KB, patch)
2013-09-11 05:18 PDT, Gábor Ábrahám 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gábor Ábrahám
Comment 1 2013-09-11 05:18:35 PDT
Created attachment 211299 [details] Proposed patch Proposed fix.
Csaba Osztrogonác
Comment 2 2013-09-11 06:41:40 PDT
Comment on attachment 211299 [details] Proposed patch LGTM, r=me.
Csaba Osztrogonác
Comment 3 2013-09-11 06:42:13 PDT
Lucas, could you restart the build.webkit.org after it landed please?
WebKit Commit Bot
Comment 4 2013-09-11 07:06:29 PDT
Comment on attachment 211299 [details] Proposed patch Clearing flags on attachment: 211299 Committed r155523: <http://trac.webkit.org/changeset/155523>
WebKit Commit Bot
Comment 5 2013-09-11 07:06:32 PDT
All reviewed patches have been landed. Closing bug.
Lucas Forschler
Comment 6 2013-09-11 08:02:37 PDT
This patch breaks the buildbot, the indentation appears incorrect on line 674. I've udpated the master to r155522, and restarted it. Please land a fix and i'll restart again.
Csaba Osztrogonác
Comment 7 2013-09-11 10:31:53 PDT
(In reply to comment #6) > This patch breaks the buildbot, the indentation appears incorrect on line 674. I've udpated the master to r155522, and restarted it. > > Please land a fix and i'll restart again. Ouch ... Sorry for the breakage. I landed the fix in http://trac.webkit.org/changeset/155538 The problem was that rniwa used 3 spaces for indentation in http://trac.webkit.org/changeset/105848 Additionaly there was a typo in the patch. @Gábor, please run mastercfg_unittest.py next time yout touch the master.cfg (I thought, you did it ... )
Lucas Forschler
Comment 8 2013-09-11 11:29:38 PDT
master restarted. Please watch out for any funky-ness.
Note You need to log in before you can comment on or make changes to this bug.