Bug 120461

Summary: Move element renderer creation out of NodeRenderingContext
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, d-r, esprehn+autocc, fmalita, kangil.han, kling, pdr, schenney, WebkitBugTracker
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-08-29 04:04:42 PDT
Whittle down NodeRenderingContext.
Attachments
patch (19.42 KB, patch)
2013-08-29 04:49 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-29 04:49:53 PDT
Created attachment 209965 [details] patch
Andreas Kling
Comment 2 2013-08-29 04:55:44 PDT
Comment on attachment 209965 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209965&action=review r=me, nice! > Source/WebCore/style/StyleResolveTree.cpp:137 > + if (!element.document()->shouldCreateRenderers()) > + return false; We should hoist this check up to the Document level so we don't have to run it for every Element.
Antti Koivisto
Comment 3 2013-08-29 05:48:31 PDT
https://trac.webkit.org/r154806
Note You need to log in before you can comment on or make changes to this bug.