Bug 120452
| Summary: | Inline ComputeFloatOffsetAdapter::updateOffsetIfNeeded and rangesIntersect | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | barraclough, dino, hyatt, kling, koivisto, simon.fraser |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Merge https://chromium.googlesource.com/chromium/blink/+/4a84548b66b982f833d669097e83ce23d76bc1d2
Both functions are only called from ComputeFloatOffsetAdapter::collectIfNeeded, so shouldn't add much to binary size, in fact when I checked it seemed to actually result in a (slightly) smaller binary.
Gives roughly 400ms gain on my z620 for bookish from tough_layout_cases, and roughly 7.5% gain on floats_50_100 from blink_perf on linux.
No Patch:
Binary Size: 138797688
*RESULT times: page_load_time= [3006,2902,2860,2791,2826,2946,2888,2797,2805,3250,2918,2845,2800,2825,2814,2922,3275,2817,3172] ms
Avg times: 2918.894737ms
Sd times: 152.052584ms
Pages: [floats_50_100.html]
*RESULT floats_50_100: floats_50_100= [249.058999936,248.852000106,249.21899999,249.039000017,249.643999967] ms
Avg floats_50_100: 249.162600ms
Sd floats_50_100: 0.298919ms
With Patch:
Binary Size: 138797176
*RESULT times: page_load_time= [2660,2417,2517,2488,2427,2479,2486,2480,2462,2476,2531,2465,2486,2476,2535,2504,2462,2586,2489] ms
Avg times: 2496.105263ms
Sd times: 54.863360ms
Pages: [floats_50_100.html]
*RESULT floats_50_100: floats_50_100= [231.318000006,229.234999977,229.611000046,229.673999944,229.234000086] ms
Avg floats_50_100: 229.814400ms
Sd floats_50_100: 0.865226ms
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
*** This bug has been marked as a duplicate of bug 120237 ***