Bug 120237 - Optimize FloatIntervalSearchAdapter::collectIfNeeded
Summary: Optimize FloatIntervalSearchAdapter::collectIfNeeded
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
: 120452 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-23 14:44 PDT by Bem Jones-Bey
Modified: 2013-08-28 20:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.28 KB, patch)
2013-08-23 15:04 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (14.23 KB, patch)
2013-08-26 13:31 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Patch (14.23 KB, patch)
2013-08-26 14:03 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2013-08-23 14:44:26 PDT 
Optimize FloatIntervalSearchAdapter::collectIfNeeded
Comment 1 Bem Jones-Bey 2013-08-23 15:04:10 PDT 
Created attachment 209515 [details]
Patch

Port patches from Blink
Comment 2 Dave Hyatt 2013-08-26 11:11:05 PDT 
Comment on attachment 209515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209515&action=review

r=me

> Source/WebCore/ChangeLog:20
> +        significatly changed by using the outermost float instead of the last

Typo. "significantly"
Comment 3 Bem Jones-Bey 2013-08-26 13:31:27 PDT 
Created attachment 209673 [details]
Patch

Update for review comment
Comment 4 WebKit Commit Bot 2013-08-26 13:33:57 PDT 
Comment on attachment 209673 [details]
Patch

Rejecting attachment 209673 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 209673, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Dave Hyatt found in /Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/1584024
Comment 5 Bem Jones-Bey 2013-08-26 14:03:42 PDT 
Created attachment 209675 [details]
Patch

Fix reviewer name
Comment 6 WebKit Commit Bot 2013-08-26 14:34:41 PDT 
Comment on attachment 209675 [details]
Patch

Clearing flags on attachment: 209675

Committed r154641: <http://trac.webkit.org/changeset/154641>
Comment 7 WebKit Commit Bot 2013-08-26 14:34:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryosuke Niwa 2013-08-28 20:44:52 PDT 
*** Bug 120452 has been marked as a duplicate of this bug. ***