Bug 120435

Summary:

Decrease number of workers used in NRWT by the Windows port

Product:

WebKit

Reporter:

Roger Fong <roger_fong>

Component:

Tools / Tests

Assignee:

Roger Fong <roger_fong>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, dpranke, glenn, roger_fong

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	bfulgham: review+

Description Roger Fong 2013-08-28 12:26:00 PDT

Right now we're maxing out the number of workers.
This tends to cause various issues such as test results being off by 1, flakiness, and occasional timeouts.
Maxing out the number of threads might actually in some cases slow down the test cases rather than speed them up.
Decreasing the number of workers to half the available cores (just to be on the safe side).

Comment 1 Roger Fong 2013-08-28 13:19:57 PDT

Created attachment 209918 [details]
Patch

Comment 2 Brent Fulgham 2013-08-28 13:28:38 PDT

Comment on attachment 209918 [details]
Patch

Yes! r=me.

Comment 3 Roger Fong 2013-08-28 13:33:43 PDT

Awesome thanks, hopefully we'll start seeing some more stability in the bots now.
Committed: https://trac.webkit.org/r154776