Bug 120435

Summary: Decrease number of workers used in NRWT by the Windows port
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Roger Fong <roger_fong>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dpranke, glenn, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch bfulgham: review+

Roger Fong
Reported 2013-08-28 12:26:00 PDT
Right now we're maxing out the number of workers. This tends to cause various issues such as test results being off by 1, flakiness, and occasional timeouts. Maxing out the number of threads might actually in some cases slow down the test cases rather than speed them up. Decreasing the number of workers to half the available cores (just to be on the safe side).
Attachments
Patch (1.14 KB, patch)
2013-08-28 13:19 PDT, Roger Fong 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-08-28 13:19:57 PDT
Created attachment 209918 [details] Patch
Brent Fulgham
Comment 2 2013-08-28 13:28:38 PDT
Comment on attachment 209918 [details] Patch Yes! r=me.
Roger Fong
Comment 3 2013-08-28 13:33:43 PDT
Awesome thanks, hopefully we'll start seeing some more stability in the bots now. Committed: https://trac.webkit.org/r154776
Note You need to log in before you can comment on or make changes to this bug.