Bug 120428

Summary:

[Windows] Provide useful error messages for WebKitErrorDomain errors

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	andersca: review+

Brent Fulgham

Reported 2013-08-28 11:04:48 PDT

The current handlers for things like "Content with specified MIME type can't be shown" and "Not allowed to use restricted network port" simply return an empty string for display to the user. This results in mysterious blank "OK" alert boxes that are the only clue that something went wrong with Windows WebKit when attempting to view some content. This bug uses the existing WEB_UI_STRINGS defined for these error codes and allows Windows WebKit to display them.

Attachments
Patch (6.65 KB, patch) 2013-08-28 11:08 PDT, Brent Fulgham	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2013-08-28 11:05:45 PDT

<rdar://problem/14858310>

Brent Fulgham

Comment 2 2013-08-28 11:08:29 PDT

Created attachment 209906 [details] Patch

WebKit Commit Bot

Comment 3 2013-08-28 11:11:53 PDT

Attachment 209906 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brent Fulgham

Comment 4 2013-08-28 11:21:15 PDT

(In reply to comment #3) > Attachment 209906 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp']" exit_code: 1 > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:883: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:893: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1147: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1151: Line contains invalid UTF-8 (or Unicode replacement character). [readability/utf8] [5] > Total errors found: 4 in 2 files The character codes must be present to match the existing string keys in the localizedStrings file.

Brent Fulgham

Comment 5 2013-08-28 11:44:28 PDT

Committed r154764: <http://trac.webkit.org/changeset/154764>

Note You need to log in before you can comment on or make changes to this bug.