Bug 120415

Summary:

[curl] Remove unused includes.

Product:

WebKit

Reporter:

Tamas Czene <tczene>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, galpeter

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch	none
updated patch	ossy: review+, commit-queue: commit-queue-
updated patch	andersca: review+, andersca: commit-queue+
updated patch	none

Tamas Czene

Reported 2013-08-28 07:13:43 PDT

[curl] Remove unused includes.

Attachments
proposed patch (2.04 KB, patch) 2013-08-28 07:14 PDT, Tamas Czene	no flags	Details Formatted Diff Diff
updated patch (2.18 KB, patch) 2013-11-06 01:24 PST, Gergő Balogh	ossy: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
updated patch (1.48 KB, patch) 2013-11-11 06:30 PST, Gergő Balogh	andersca: review+ andersca: commit-queue+	Details Formatted Diff Diff
updated patch (2.11 KB, patch) 2013-11-11 07:14 PST, Gergő Balogh	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Tamas Czene

Comment 1 2013-08-28 07:14:57 PDT

Created attachment 209883 [details] proposed patch

Brent Fulgham

Comment 2 2013-10-30 10:22:13 PDT

Comment on attachment 209883 [details] proposed patch r=me.

WebKit Commit Bot

Comment 3 2013-10-30 10:28:19 PDT

Comment on attachment 209883 [details] proposed patch Rejecting attachment 209883 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 209883, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WebCore/platform/network/curl/ProxyServerCurl.cpp.rej patching file Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp patching file Source/WebCore/platform/network/curl/ResourceHandleManager.cpp Hunk #1 FAILED at 39. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/network/curl/ResourceHandleManager.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/17038242

Peter Gal

Comment 4 2013-10-30 10:30:29 PDT

It seems it seems the patch is a bit outdated :)

Gergő Balogh

Comment 5 2013-11-06 01:24:45 PST

Created attachment 216153 [details] updated patch

Csaba Osztrogonác

Comment 6 2013-11-07 03:44:31 PST

Comment on attachment 216153 [details] updated patch r=me

WebKit Commit Bot

Comment 7 2013-11-07 03:47:24 PST

Comment on attachment 216153 [details] updated patch Rejecting attachment 216153 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 216153, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/22778149

Csaba Osztrogonác

Comment 8 2013-11-07 04:39:13 PST

Comment on attachment 216153 [details] updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=216153&action=review > Source/WebCore/ChangeLog:10 > + No new tests (OOPS!). Please remove this line

Gergő Balogh

Comment 9 2013-11-11 06:30:11 PST

Created attachment 216563 [details] updated patch

WebKit Commit Bot

Comment 10 2013-11-11 06:31:49 PST

Attachment 216563 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gergő Balogh

Comment 11 2013-11-11 07:14:22 PST

Created attachment 216570 [details] updated patch

WebKit Commit Bot

Comment 12 2013-11-11 09:35:25 PST

Comment on attachment 216570 [details] updated patch Clearing flags on attachment: 216570 Committed r159053: <http://trac.webkit.org/changeset/159053>

WebKit Commit Bot

Comment 13 2013-11-11 09:35:27 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.