Bug 120378

Summary:

Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines

Product:

WebKit

Reporter:

Bem Jones-Bey <bjonesbe>

Component:

New Bugs

Assignee:

Bem Jones-Bey <bjonesbe>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Bem Jones-Bey

Reported 2013-08-27 15:24:09 PDT

Code cleanup: rename FloatIntervalSearchAdapter tand remove unnecessary inlines

Attachments
Patch (9.96 KB, patch) 2013-08-27 15:30 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Patch (9.72 KB, patch) 2013-08-28 09:44 PDT, Bem Jones-Bey	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Bem Jones-Bey

Comment 1 2013-08-27 15:30:53 PDT

Created attachment 209810 [details] Patch Port patches from Blink

Darin Adler

Comment 2 2013-08-27 18:12:51 PDT

Comment on attachment 209810 [details] Patch Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.

Bem Jones-Bey

Comment 3 2013-08-28 08:38:51 PDT

(In reply to comment #2) > (From update of attachment 209810 [details]) > Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process. Can you cite any specific changes that I could make to the way that I write changelogs for ports from Blink that would make you feel more comfortable with it? I'm not particularly attached to any specific format, so if there's a way I could write it that you prefer, I would be happy to do that.

Bem Jones-Bey

Comment 4 2013-08-28 09:44:20 PDT

Created attachment 209899 [details] Patch Review feedback

WebKit Commit Bot

Comment 5 2013-08-28 10:10:59 PDT

Comment on attachment 209899 [details] Patch Clearing flags on attachment: 209899 Committed r154758: <http://trac.webkit.org/changeset/154758>

WebKit Commit Bot

Comment 6 2013-08-28 10:11:01 PDT

All reviewed patches have been landed. Closing bug.

Ryosuke Niwa

Comment 7 2013-08-28 16:25:34 PDT

This was a merge of https://chromium.googlesource.com/chromium/blink/+/9255dec730afe43bc349d45a7dc282fa6bdc303e

Ryosuke Niwa

Comment 8 2013-08-28 16:26:02 PDT

And https://chromium.googlesource.com/chromium/blink/+/6a478017abfeff20de46c91aed6d6c3a8d0082bf

Note You need to log in before you can comment on or make changes to this bug.