Bug 120378

Summary: Code cleanup: rename FloatIntervalSearchAdapter and remove unnecessary inlines
Product: WebKit Reporter: Bem Jones-Bey <bjonesbe>
Component: New BugsAssignee: Bem Jones-Bey <bjonesbe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Bem Jones-Bey 2013-08-27 15:24:09 PDT 
Code cleanup: rename FloatIntervalSearchAdapter tand remove unnecessary inlines
Comment 1 Bem Jones-Bey 2013-08-27 15:30:53 PDT 
Created attachment 209810 [details]
Patch

Port patches from Blink
Comment 2 Darin Adler 2013-08-27 18:12:51 PDT 
Comment on attachment 209810 [details]
Patch

Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.
Comment 3 Bem Jones-Bey 2013-08-28 08:38:51 PDT 
(In reply to comment #2)
> (From update of attachment 209810 [details])
> Changes are OK. But I don’t really want to read about Blink. I’d like to read about the merits of the change, not a blow-by-blow of the Blink development process.

Can you cite any specific changes that I could make to the way that I write changelogs for ports from Blink that would make you feel more comfortable with it? I'm not particularly attached to any specific format, so if there's a way I could write it that you prefer, I would be happy to do that.
Comment 4 Bem Jones-Bey 2013-08-28 09:44:20 PDT 
Created attachment 209899 [details]
Patch

Review feedback
Comment 5 WebKit Commit Bot 2013-08-28 10:10:59 PDT 
Comment on attachment 209899 [details]
Patch

Clearing flags on attachment: 209899

Committed r154758: <http://trac.webkit.org/changeset/154758>
Comment 6 WebKit Commit Bot 2013-08-28 10:11:01 PDT 
All reviewed patches have been landed.  Closing bug.