Bug 120377

Summary:

SVG clipping, masking, and gradients-on-text do not respect the device scale factor

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

SVG

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dino, d-r, eflews.bot, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, krit, pdr, rego+ews, schenney, simon.fraser, webkit-ews, xan.lopez, zimmermann

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
testcase	none
screenshot of test case	none
prelim	webkit-ews: commit-queue-
patch	simon.fraser: review+

Tim Horton

Reported 2013-08-27 14:54:35 PDT

See the attached test case. calculateTransformationToOutermostCoordinateSystem, which we frequently use to find the transform to map rects through for creation of image buffers, doesn't respect the device scale factor, leading to blurry rendering in HiDPI contexts. <rdar://problem/14777944>

Attachments
testcase (2.78 KB, text/html) 2013-08-27 14:54 PDT, Tim Horton	no flags	Details
screenshot of test case (71.38 KB, image/png) 2013-08-27 14:55 PDT, Tim Horton	no flags	Details
prelim (3.75 KB, patch) 2013-08-27 15:35 PDT, Tim Horton	webkit-ews: commit-queue-	Details Formatted Diff Diff
patch (6.08 KB, patch) 2013-08-29 16:06 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2013-08-27 14:54:53 PDT

Created attachment 209803 [details] testcase

Tim Horton

Comment 2 2013-08-27 14:55:19 PDT

Created attachment 209804 [details] screenshot of test case

Tim Horton

Comment 3 2013-08-27 15:35:37 PDT

Created attachment 209812 [details] prelim have to go work on something else but here's where we're at

Early Warning System Bot

Comment 4 2013-08-29 15:31:36 PDT

Comment on attachment 209812 [details] prelim Attachment 209812 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1623716

Early Warning System Bot

Comment 5 2013-08-29 15:32:35 PDT

Comment on attachment 209812 [details] prelim Attachment 209812 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1643099

EFL EWS Bot

Comment 6 2013-08-29 16:04:26 PDT

Comment on attachment 209812 [details] prelim Attachment 209812 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1635358

Tim Horton

Comment 7 2013-08-29 16:06:39 PDT

Created attachment 210042 [details] patch

Tim Horton

Comment 8 2013-08-29 16:20:09 PDT

Comment on attachment 210042 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=210042&action=review > Source/WebCore/rendering/svg/SVGRenderingContext.cpp:35 > +#include "RenderLayerBacking.h" I don’t need this anymore.

Tim Horton

Comment 9 2013-08-29 17:07:56 PDT

https://trac.webkit.org/r154856

Note You need to log in before you can comment on or make changes to this bug.