| Summary: | Stop using deleteAllValues in CClass | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abrhm, allan.jensen, hausmann, kadam, ossy, zarvai | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 120398 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2013-08-27 14:18:32 PDT
Created attachment 209801 [details]
Patch
Comment on attachment 209801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review k > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS Committed r154708: <http://trac.webkit.org/changeset/154708> Comment on attachment 209801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review > Source/WebCore/bridge/c/c_class.cpp:101 > + OwnPtr<Field> field = adoptPtr(new CField(ident)); > + m_fields.set(name.impl(), field.release()); This would read better without the local variable and without the release(). (In reply to comment #3) > Committed r154708: <http://trac.webkit.org/changeset/154708> It broke all plugin tests on GTK and Qt WK1: - http://build.webkit.org/builders/Qt%20Linux%20Release/builds/62478 - http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20WK1/builds/3852 |