Bug 120370

Summary: AppleWin port should delete sem lock files in /dev/shm during cleanup tasks for NRWT
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dpranke, glenn, lforschler, roger_fong
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch bfulgham: review+

Roger Fong
Reported 2013-08-27 11:45:39 PDT
With our current version of cygwin and python there is a bug where the sem lock files do not get removed from /dev/shm. /dev/shm eventually fills up with tons of sem lock files and we issues where we get "OSError raised: [Errno 17] File exists" due to file collisions. However, installing other versions of cygwin/python would lead to tons of other issues which we've previously discovered so we just need to work around this issue here.
Attachments
patch (1.48 KB, patch)
2013-08-27 11:55 PDT, Roger Fong 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-08-27 11:55:19 PDT
Created attachment 209789 [details] patch
Roger Fong
Comment 2 2013-08-27 11:55:39 PDT
tested this fix locally on a bot that had this issue, and it did the trick
Brent Fulgham
Comment 3 2013-08-27 11:58:11 PDT
Comment on attachment 209789 [details] patch This looks great! Does this cleanup code get called at startup of the test harness, or only when ending tests? If it doesn't, maybe we could add a belt-and-suspenders step to kill any locks when the test rig is first started?
Dirk Pranke
Comment 4 2013-08-27 12:14:58 PDT
cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :).
Roger Fong
Comment 5 2013-08-27 12:36:08 PDT
(In reply to comment #4) > cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :). O cool, I'll move it there. Thanks!
Roger Fong
Comment 6 2013-08-27 12:41:39 PDT
<rdar://problem/14621844> Committed: http://trac.webkit.org/changeset/154704
Note You need to log in before you can comment on or make changes to this bug.