Bug 120367

Summary: No need for generalPasteboard (aside from "global selection mode")
Product: WebKit Reporter: Darin Adler <darin>
Component: PlatformAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 120392    
Attachments:
Description Flags
Patch none

Darin Adler
Reported 2013-08-27 10:04:00 PDT
No need for generalPasteboard (aside from "global selection mode")
Attachments
Patch (5.91 KB, patch)
2013-08-27 10:06 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-08-27 10:06:38 PDT
Created attachment 209783 [details] Patch
Alexey Proskuryakov
Comment 2 2013-08-27 10:36:12 PDT
I got confused by your IRC statement that this patch fixes the root cause of bug 113094, so I'd like to chat about how pasteboard works (especially as I'm going to look into drag&drop handling in WKTR soon).
Build Bot
Comment 3 2013-08-27 11:45:48 PDT
Comment on attachment 209783 [details] Patch Attachment 209783 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1594008
Alexey Proskuryakov
Comment 4 2013-08-27 11:59:45 PDT
Comment on attachment 209783 [details] Patch r=me I think that ultimately, using the same class for long-living Pasteboard handles (like those inside Clipboard object) and for these single-shot ones is confusing. We need to keep changeCount updated for Clipboard but don't care about it here.
Darin Adler
Comment 5 2013-08-27 15:02:03 PDT
Comment on attachment 209783 [details] Patch Windows build failures were unrelated to this patch.
WebKit Commit Bot
Comment 6 2013-08-27 15:24:17 PDT
Comment on attachment 209783 [details] Patch Clearing flags on attachment: 209783 Committed r154712: <http://trac.webkit.org/changeset/154712>
WebKit Commit Bot
Comment 7 2013-08-27 15:24:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.