Bug 120351

Summary: Add USE(PROTECTION_SPACE_AUTH_CALLBACK) guards to canAuthenticateAgainstProtectionSpace()
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, kling, koivisto, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 108832    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2013-08-27 03:06:52 PDT
virtual void NetworkLoaderClient::canAuthenticateAgainstProtectionSpace(NetworkResourceLoader*, const WebCore::ProtectionSpace&) = 0; is implemented by AsynchronousNetworkLoaderClient and SynchronousNetworkLoaderClient. - AsynchronousNetworkLoaderClient implementation uses Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace() - SynchronousNetworkLoaderClient implementation uses NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace() Both of them are inside USE(PROTECTION_SPACE_AUTH_CALLBACK), so all functions use them should be inside the same if guard.
Attachments
Patch (6.83 KB, patch)
2013-08-27 03:08 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2013-08-27 03:08:33 PDT
Created attachment 209739 [details] Patch
Csaba Osztrogonác
Comment 2 2013-08-30 10:02:37 PDT
ping for review, please :)
WebKit Commit Bot
Comment 3 2013-08-30 10:49:51 PDT
Comment on attachment 209739 [details] Patch Clearing flags on attachment: 209739 Committed r154895: <http://trac.webkit.org/changeset/154895>
WebKit Commit Bot
Comment 4 2013-08-30 10:49:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.