Bug 120337

Summary:

CMakeLists.txt for EFL port contains files not required by build process.

Product:

WebKit

Reporter:

Michał Poteralski <m.poteralski>

Component:

WebKit EFL

Assignee:

Michał Poteralski <m.poteralski>

Status:

RESOLVED INVALID

Severity:

Normal

CC:

cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ryuan.choi: commit-queue-

Michał Poteralski

Reported 2013-08-26 18:19:55 PDT

CMakeLists: Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt contains files not required by build process. There are *.edc and *.png files that are not necessary. All .edc files required by build process should be contained only in default.edc file.

Attachments
Patch (7.03 KB, patch) 2013-08-26 19:11 PDT, Michał Poteralski	no flags	Details Formatted Diff Diff
Patch (7.26 KB, patch) 2013-08-26 19:35 PDT, Michał Poteralski	ryuan.choi: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2013-08-26 18:59:33 PDT

(In reply to comment #0) > CMakeLists: Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt contains files not required by build process. > There are *.edc and *.png files that are not necessary. All .edc files required by build process should be contained only in default.edc file. I noticed it before. Go ahead !

Michał Poteralski

Comment 2 2013-08-26 19:11:55 PDT

Created attachment 209706 [details] Patch

Gyuyoung Kim

Comment 3 2013-08-26 19:17:15 PDT

Comment on attachment 209706 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209706&action=review > Source/WebCore/ChangeLog:7 > + Missing patch description. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). If patch doesn't influence on behavior, remove this line. or you can mention as below, No new tests, no behavior change.

Michał Poteralski

Comment 4 2013-08-26 19:35:15 PDT

Created attachment 209708 [details] Patch

Gyuyoung Kim

Comment 5 2013-08-26 20:12:26 PDT

Comment on attachment 209708 [details] Patch r=me, but Ryuan wanted to check if there is no problem before landing.

Ryuan Choi

Comment 6 2013-08-26 21:20:09 PDT

Comment on attachment 209708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209708&action=review > Source/WebCore/ChangeLog:11 > + I've removed not required *.edc and *.png dependencies from the CMakeLists.txt file for EFL port. > + All *.edc files required during build process should be contained in default.edc file only. > + > + No new tests, no behaviour change. No, We need them for partial build(normally we are doing). If we remove them from dependency, CMake can not detect whether they are changed until we compiles all.

Gyuyoung Kim

Comment 7 2013-08-26 21:49:31 PDT

(In reply to comment #6) > (From update of attachment 209708 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=209708&action=review > > > Source/WebCore/ChangeLog:11 > > + I've removed not required *.edc and *.png dependencies from the CMakeLists.txt file for EFL port. > > + All *.edc files required during build process should be contained in default.edc file only. > > + > > + No new tests, no behaviour change. > > No, We need them for partial build(normally we are doing). > > If we remove them from dependency, CMake can not detect whether they are changed until we compiles all. Ah, I missed it. Thank you for checking it.

Note You need to log in before you can comment on or make changes to this bug.