Summary: | REGRESSION(r154640): Caused flaky crashes on a lot of editing tests (Requested by rniwa on #webkit). | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | WebKit Commit Bot <commit-queue> | ||||
Component: | New Bugs | Assignee: | WebKit Commit Bot <commit-queue> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, darin | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 81419 | ||||||
Attachments: |
|
Description
WebKit Commit Bot
2013-08-26 16:03:23 PDT
Created attachment 209687 [details] ROLLOUT of r154640 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. I see some crashes locally on another machine (strangely, not on the one where I developed this). It may be that it's actually the missing [super init] call. Same that we had in WebKit1 without any issues since 2006, and which Andy fixed a few moments ago. Will test this hypothesis quickly. Comment on attachment 209687 [details] ROLLOUT of r154640 No, an -init doesn't seem to help. Rolling out for now. Comment on attachment 209687 [details] ROLLOUT of r154640 Clearing flags on attachment: 209687 Committed r154650: <http://trac.webkit.org/changeset/154650> All reviewed patches have been landed. Closing bug. |