Bug 120319

Summary:

PageGroup::groupSettings() should return a reference

Product:

WebKit

Reporter:

Pratik Solanki <psolanki>

Component:

WebCore Misc.

Assignee:

Pratik Solanki <psolanki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling, psolanki

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Description Pratik Solanki 2013-08-26 10:35:00 PDT

PageGroup always has m_groupSettings. We should return  a reference from that method.

Comment 1 Pratik Solanki 2013-08-26 10:37:52 PDT

Created attachment 209664 [details]
Patch

Comment 2 Andreas Kling 2013-08-26 10:39:09 PDT

Comment on attachment 209664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209664&action=review

LGTM.

> Source/WebCore/page/PageGroup.h:111
> -        GroupSettings* groupSettings() const { return m_groupSettings.get(); }
> +        GroupSettings& groupSettings() const { return *m_groupSettings; }

We should also make m_groupSettings a const OwnPtr.

Comment 3 Pratik Solanki 2013-08-26 10:56:07 PDT

Committed r154618: <http://trac.webkit.org/changeset/154618>