Bug 12031

Summary: Update embedded JavaScriptCore/pcre library from 6.1 to 6.2
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ggaren, mitz
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.pcre.org/
Attachments:
Description Flags
Full pcre-6.1 to 6.2 diff
none
Patch v1 ggaren: review+

David Kilzer (:ddkilzer)
Reported 2006-12-29 18:37:37 PST
The current embedded JavaScriptCore/pcre library is version 6.1 (r10495) with some fixes from version 6.2 included in r14736. I'm wondering if I should continue this work? Various enhancements and bug fixes have been included in versions 6.3-6.7 and 7.0.
Attachments
Full pcre-6.1 to 6.2 diff (61.92 KB, patch)
2006-12-29 18:47 PST, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v1 (5.38 KB, patch)
2006-12-29 18:48 PST, David Kilzer (:ddkilzer) 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-12-29 18:47:11 PST
Created attachment 12114 [details] Full pcre-6.1 to 6.2 diff Full diff between pcre-6.1 and 6.2 for reference.
David Kilzer (:ddkilzer)
Comment 2 2006-12-29 18:48:01 PST
Created attachment 12115 [details] Patch v1 Brings JavaScriptCore/pcre up to version 6.2.
Geoffrey Garen
Comment 3 2006-12-29 18:58:55 PST
Comment on attachment 12115 [details] Patch v1 r=me (assuming the layout tests and javascriptcore tests pass). It would be nice to keep in step with PCRE, and upgrade to 7.x. The only reason we don't keep in lockstep is that it can be a lot of work to port PCRE to use UTF16 strings.
David Kilzer (:ddkilzer)
Comment 4 2006-12-29 19:19:53 PST
(In reply to comment #3) > (From update of attachment 12115 [details] [edit]) > r=me (assuming the layout tests and javascriptcore tests pass). No regressions in layout tests or javascriptcore tests. Committed revision 18483.
Note You need to log in before you can comment on or make changes to this bug.