Bug 120294

Summary:

[WK2] Buildfix for non Mac platforms

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, beidson, commit-queue, kling, ossy, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

108832

Attachments:

Description	Flags
Patch	none
Patch	none

Description Csaba Osztrogonác 2013-08-26 02:47:27 PDT

We should check if __MAC_OS_X_VERSION_MIN_REQUIRED macro is defined or not:

-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

Patch is coming.

Comment 1 Csaba Osztrogonác 2013-08-26 02:49:08 PDT

Created attachment 209630 [details]
Patch

Comment 2 Anders Carlsson 2013-08-26 08:03:32 PDT

Comment on attachment 209630 [details]
Patch

It's probably better to use PLATFORM(MAC) here.

Comment 3 Darin Adler 2013-08-26 10:23:10 PDT

Comment on attachment 209630 [details]
Patch

Please use PLATFORM(MAC) as suggested by Anders.

Comment 4 Csaba Osztrogonác 2013-08-26 14:53:22 PDT

Created attachment 209680 [details]
Patch

Comment 5 WebKit Commit Bot 2013-08-26 15:33:35 PDT

Comment on attachment 209680 [details]
Patch

Clearing flags on attachment: 209680

Committed r154646: <http://trac.webkit.org/changeset/154646>

Comment 6 WebKit Commit Bot 2013-08-26 15:33:37 PDT

All reviewed patches have been landed.  Closing bug.